[jira] [Commented] (LOG4J2-2788) Replace ThreadContext.EmptyIterator with JDK variant

["Marius Volkhart (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042944#comment-17042944 ] 

Marius Volkhart commented on LOG4J2-2788:
-----------------------------------------

I'm happy to submit a PR for this work if it is desirable.

> Replace ThreadContext.EmptyIterator with JDK variant
> ----------------------------------------------------
>
>                 Key: LOG4J2-2788
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2788
>             Project: Log4j 2
>          Issue Type: Story
>          Components: Core
>    Affects Versions: 2.13.0
>            Reporter: Marius Volkhart
>            Priority: Minor
>
> {{ThreadContext.java}} has a class, {{EmptyIterator}}, used in conjunction with the {{EmptyThreadContextStack}}. I'd like to propose replacing it with {{Collections.emptyIterator()}}.
> It was unclear from the comments and commit messages whether or not the {{EmptyIterator}} was used because {{Collections.emptyIterator()}} was not available, or because it was deemed unfit at the time. Log4J 2 requires Java 8 now, so using Java 7 classes is possible. 
> Switching to the JDK variant results in a slight change in behavior. The {{EmptyIterator}} no-ops on a call to {{remove()}}. The JDK variant throws an {{IllegalStateException}}. This seems acceptable since all other mutator methods of the {{EmptyThreadContextStack}} throw an {{UnsupportedOperationException}}. While the exceptions aren't the same, it's clear that mutating isn't supported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)