You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2015/02/21 02:09:32 UTC
Review Request 31251: Fix swallowed exceptions in health check test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Zameer Manji.
Repository: aurora
Description
-------
Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
Diffs
-----
src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
Diff: https://reviews.apache.org/r/31251/diff/
Testing
-------
Ran the following about 100 times:
THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Brian Wickman <wi...@apache.org>.
> On Feb. 21, 2015, 2:10 a.m., Aurora ReviewBot wrote:
> > Master (e5de618) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> > src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> > src.test.python.apache.aurora.client.config ..... SUCCESS
> > src.test.python.apache.aurora.client.factory ..... SUCCESS
> > src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> > src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
> > src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
> > src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
> > src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
> > src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
> > src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
> > src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
> > src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
> > src.test.python.apache.aurora.common.test_transport ..... SUCCESS
> > src.test.python.apache.aurora.config.test_base ..... SUCCESS
> > src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
> > src.test.python.apache.aurora.config.test_loader ..... SUCCESS
> > src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.executor_detector ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> > src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> > src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> > src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> > src.test.python.apache.aurora.executor.gc_executor ..... FAILURE
> > src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> > src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
> > src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
> > src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
> > src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
> >
> > FAILURE
> >
> > [31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
I ran gc_executor test locally a dozen times and managed to get this one:
==================== FAILURES ====================
________________ test_gc_lifetime ________________
def test_gc_lifetime():
with run_gc_with_timeout(maximum_executor_lifetime=Amount(500, Time.MILLISECONDS)) as (
proxy_driver, executor):
executor._clock.tick(1)
proxy_driver.stopped.wait(timeout=1.0)
> assert proxy_driver.stopped.is_set()
E assert <bound method _Event.isSet of <threading._Event object at 0x1069f0090>>()
E + where <bound method _Event.isSet of <threading._Event object at 0x1069f0090>> = <threading._Event object at 0x1069f0090>.is_set
E + where <threading._Event object at 0x1069f0090> = <test_gc_executor.ProxyDriver object at 0x1069f0350>.stopped
src/test/python/apache/aurora/executor/test_gc_executor.py:509: AssertionError
====== 1 failed, 27 passed in 11.85 seconds ======
src.test.python.apache.aurora.executor.gc_executor ..... FAILURE
FAILURE
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73380
-----------------------------------------------------------
On Feb. 21, 2015, 1:09 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 1:09 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73380
-----------------------------------------------------------
Master (e5de618) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... FAILURE
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 21, 2015, 1:09 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 1:09 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73650
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 23, 2015, 11:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 11:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
> src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73688
-----------------------------------------------------------
Ship it!
Master (277ac43) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 23, 2015, 8:23 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 8:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
> src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73658
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Feb. 23, 2015, 12:23 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
> src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73707
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 23, 2015, 3:09 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 3:09 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
> src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 11:09 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Last one
1. Make sure executor threads are stopped in tests.
2. Make sure we always call .converge after .start.
Repository: aurora
Description
-------
Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
Diff: https://reviews.apache.org/r/31251/diff/
Testing
-------
Ran the following about 100 times:
THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 8:23 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
s/log.warning/log.error/
Repository: aurora
Description
-------
Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
Diff: https://reviews.apache.org/r/31251/diff/
Testing
-------
Ran the following about 100 times:
THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73647
-----------------------------------------------------------
src/main/python/apache/aurora/executor/common/health_checker.py
<https://reviews.apache.org/r/31251/#comment120044>
log.error since this is completely unexpected behaviour
- Zameer Manji
On Feb. 23, 2015, 11:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 11:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
> src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31251: Fix swallowed exceptions in health check
test.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 7:50 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Remove mixing of real and fake clocks in gc executor test. Remove timeouts from clock convergence, since those will be sources of flakiness.
Repository: aurora
Description
-------
Fix swallowed exceptions in health check test. One of the health checkers was raising uncaught exceptions on a separate thread. The Python interpreter on CI *might* behave slightly differently and fail here. To be honest I've not been able to reproduce the CI behavior, so hopefully buildbot can chime in here.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6
Diff: https://reviews.apache.org/r/31251/diff/
Testing
-------
Ran the following about 100 times:
THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman