[GitHub] curator pull request: Curator 94

[Lunanne <gi...@git.apache.org>]

Github user Lunanne commented on the pull request:

    https://github.com/apache/curator/pull/2#issuecomment-134506044
  
    First of all thank you for this PR, I was looking into some other issues with permanent service types and this would certainly have been a big problem as I did expect permanent service types to last beyond the lifetime of Curator's service discovery.
    
    A slightly related question (I hope), looking at your diff you don't seem to be doing anything for the unregistration of these services. Looking at https://github.com/apache/curator/blob/master/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceDiscoveryImpl.java#L241
    as a result of your change of not putting them in the services map wouldn't that mean they cannot be unregistered at all?
    Also the current implementation of unregistration means that services cannot be unregistered using a different servicediscovery instance than they were registered with, which would be very useful with permanent service types.
    
    Note: As a user, I think not being able to update permanent servicetypes could easily be worked around by unregistering and reregistering them with the new information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---