You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/04/16 19:43:36 UTC
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #239:
PROTON-2190 Fix url_test.go on macOS
jiridanek commented on a change in pull request #239: PROTON-2190 Fix url_test.go on macOS
URL: https://github.com/apache/qpid-proton/pull/239#discussion_r409805516
##########
File path: go/pkg/amqp/url_test.go
##########
@@ -32,13 +35,6 @@ func ExampleParseURL() {
"amqps://host",
"/path",
"",
- ":1234",
- // Taken out because the go 1.4 URL parser isn't the same as later
Review comment:
It is an old comment. It is really about go 1.4 when the test apparently broke for the first time, due to parsing differences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org