You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2013/05/09 07:05:17 UTC

[jira] [Updated] (LUCENE-4990) Improve MockDirectoryWrapper.sync

     [ https://issues.apache.org/jira/browse/LUCENE-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-4990:
-------------------------------

    Attachment: LUCENE-4990.patch

Patch with the mentioned fixes. Note that now I don't remove all names from unsynced files, only the ones that successfully synced.
                
> Improve MockDirectoryWrapper.sync
> ---------------------------------
>
>                 Key: LUCENE-4990
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4990
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/test-framework
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4990.patch
>
>
> Currently MockDirWrapper always calls delegate.sync() with a comment that we can relax this to not wear out the hardware for tests. The issue, as discussed on this thread http://lucene.markmail.org/thread/eozdsbdahzhjvizj, is related to NRTCachingDirectory and RateLimiter. The improvements I'd like to make under this issue are:
> * Call delgeate.sync() if:
> ** rarely()
> ** delegate is NRTCachingDir
> ** delegate is RateLimitedDirWrapper and its delegate is NRTCachingDir
> ** delegate is TrackingDirWrapper and its delegate is NRTCachingDir
> * Also, today the method either fails to sync all files or succeeds. Rather, we can improve this to randomly throw IOE on each file.
> Any other Directories that can cause issues when sync() isn't called?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org