[GitHub] [mina-sshd] ggrandes commented on a change in pull request #141: [SSHD-1033]: Fix use DynamicPortForwarding + LocalPortForwarding

[GitBox <gi...@apache.org>]

ggrandes commented on a change in pull request #141:
URL: https://github.com/apache/mina-sshd/pull/141#discussion_r454545978



##########
File path: sshd-core/src/main/java/org/apache/sshd/common/forward/DefaultForwardingFilter.java
##########
@@ -964,7 +965,7 @@ protected void invokePortEventListenerSignallerHolders(
 
     @Override
     protected synchronized Closeable getInnerCloseable() {
-        return builder().parallel(toString(), dynamicLocal.values()).close(acceptor).build();
+        return builder().parallel(toString(), dynamicLocal.values()).close(dynamicAcceptor).build();

Review comment:
       It is possible, but honestly, I don't know the sshd code enough and I just let myself be guided by that "dynamicLocal.values()"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org