You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by br...@apache.org on 2009/03/24 01:08:45 UTC
svn commit: r757610 -
/incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb
Author: bryanduxbury
Date: Tue Mar 24 00:08:45 2009
New Revision: 757610
URL: http://svn.apache.org/viewvc?rev=757610&view=rev
Log:
THRIFT-312. rb: Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
Couldn't find any broken tests anymore, but did remove some dead code that had been commented in the binary protocol spec.
Modified:
incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb
Modified: incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb?rev=757610&r1=757609&r2=757610&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/binaryprotocolaccelerated_spec.rb Tue Mar 24 00:08:45 2009
@@ -14,83 +14,6 @@
def protocol_class
BinaryProtocolAccelerated
end
-
-# before(:each) do
-# @buffer = ""
-# @trans.stub!(:borrow).and_return { @buffer }
-# @trans.stub!(:consume!).and_return do |*args|
-# n = args.first || 0
-# @buffer.slice!(0,n)
-# end
-# end
-#
-#
-# it "should raise an exception if the message header has the wrong version" do
-# @buffer = "\000\000\000\v"
-# # @prot.should_receive(:read_i32).and_return(42)
-# lambda { @prot.read_message_begin }.should raise_error(Thrift::ProtocolException, 'Missing version identifier') do |e|
-# e.type == Thrift::ProtocolException::BAD_VERSION
-# end
-# end
-#
-# it "should encode a string with null bytes in it" do
-# foo = SpecNamespace::Hello.new(:greeting => "Hello\000World!")
-# @prot.encode_binary(foo).should == "\v\000\001\000\000\000\fHello\000World!\000"
-# end
-#
-# it "should decode a string with null bytes in it" do
-# trans = Thrift::MemoryBuffer.new("\v\000\001\000\000\000\fHello\000World!\000")
-# @prot.decode_binary(SpecNamespace::Hello.new, trans).should == SpecNamespace::Hello.new(:greeting => "Hello\000World!")
-# end
-#
-# it "should error when encoding a struct with a nil value in a list" do
-# Thrift.type_checking = false
-# sl = SpecNamespace::SimpleList
-# hello = SpecNamespace::Hello
-# # nil counts as false for bools
-# # lambda { @prot.encode_binary(sl.new(:bools => [true, false, nil, false])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:bytes => [1, 2, nil, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i16s => [1, 2, nil, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i32s => [1, 2, nil, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i64s => [1, 2, nil, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:doubles => [1.0, 2.0, nil, 3.0])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:strings => ["one", "two", nil, "three"])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:lists => [[1, 2], nil, [3, 4]])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:maps => [{1 => 2}, nil, {3 => 4}])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:sets => [Set.new([1, 2]), nil, Set.new([3, 4])])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:structs => [hello.new, nil, hello.new(:greeting => "hi")])) }.should raise_error
-# end
-#
-# it "should error when encoding a non-nil, non-correctly-typed value in a list" do
-# Thrift.type_checking = false
-# sl = SpecNamespace::SimpleList
-# hello = SpecNamespace::Hello
-# # bool should accept any value
-# # lambda { @prot.encode_binary(sl.new(:bools => [true, false, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:bytes => [1, 2, "3", 5])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i16s => ["one", 2, 3])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i32s => [[1,2], 3, 4])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:i64s => [{1 => 2}, 3, 4])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:doubles => ["one", 2.3, 3.4])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:strings => ["one", "two", 3, 4])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:lists => [{1 => 2}, [3, 4]])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:maps => [{1 => 2}, [3, 4]])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:sets => [Set.new([1, 2]), 3, 4])) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:structs => [3, "four"])) }.should raise_error
-# end
-#
-# it "should error when encoding an improper object where a container is expected" do
-# Thrift.type_checking = false
-# sl = SpecNamespace::SimpleList
-# lambda { @prot.encode_binary(sl.new(:strings => {"one" => "two", nil => "three"})) }.should raise_error
-# lambda { @prot.encode_binary(sl.new(:maps => [[1, 2]])) }.should raise_error
-# end
-#
-# it "should accept arrays and hashes as sets" do
-# Thrift.type_checking = false
-# sl = SpecNamespace::SimpleList
-# lambda { @prot.encode_binary(sl.new(:sets => [[1, 2], {3 => true, 4 => true}])) }.should_not raise_error
-# end
end
describe BinaryProtocolAcceleratedFactory do