[GitHub] [skywalking] Fine0830 commented on a diff in pull request #9020: Add Envoy internal cost metrics

[GitBox <gi...@apache.org>]

Fine0830 commented on code in PR #9020:
URL: https://github.com/apache/skywalking/pull/9020#discussion_r868774174


##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/mesh/mesh-service.json:
##########
@@ -464,6 +464,65 @@
                     "sortMetrics"
                   ],
                   "moved": false
+                },
+                {
+                  "x": 0,
+                  "y": 54,
+                  "w": 8,
+                  "h": 13,
+                  "i": "23",
+                  "type": "Widget",
+                  "metricTypes": [
+                    "readMetricsValues"
+                  ],
+                  "metrics": [
+                    "service_sidecar_internal_req_latency_nanos"
+                  ],
+                  "moved": false,
+                  "graph": {
+                    "type": "Line",
+                    "step": false,
+                    "smooth": false,
+                    "showSymbol": false,
+                    "showXAxis": true,
+                    "showYAxis": true
+                  },
+                  "widget": {
+                    "title": "Proxy Sidecar Internal Latency (Request)",
+                    "tips": "For more details to understand this metrics, refer to https://www.envoyproxy.io/docs/envoy/v1.22.0/api-v3/data/accesslog/v3/accesslog.proto.html#data-accesslog-v3-accesslogcommon"
+                  },
+                  "metricConfig": [
+                    {
+                      "unit": ""

Review Comment:
   Yep. To avoid similar problems, I will implement functions to remove unexpected data for exporting dashboards.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org