[GitHub] [hadoop] mehakmeet commented on pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

["mehakmeet (via GitHub)" <gi...@apache.org>]

mehakmeet commented on PR #5308:
URL: https://github.com/apache/hadoop/pull/5308#issuecomment-1423704609

   Have made the changes @steveloughran suggested including changing ">" to ">=". 
   
   Feel like we can have both strictly greater or greater equals for the check, the latter we would be taking a slight risk that the source file may have changed at the same time the last sync took place and we would be skipping the copy in that case, and the former in which we can have an additional copy even if there's no content changed but the mod time is same for both source and target. Shouldn't we prioritize accuracy here?
   Any more thoughts on if we should change this or keep ">="?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org