[GitHub] spark pull request: [SPARK-9516][UI] Improvement of Thread Dump Pa...

[CodingCat <gi...@git.apache.org>]

Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7910#discussion_r43588110
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
    @@ -60,44 +61,49 @@ private[ui] class ExecutorThreadDumpPage(parent: ExecutorsTab) extends WebUIPage
               }
             }
           }.map { thread =>
    -        val threadName = thread.threadName
    -        val className = "accordion-heading " + {
    -          if (threadName.contains("Executor task launch")) {
    -            "executor-thread"
    -          } else {
    -            "non-executor-thread"
    --- End diff --
    
    I think it is just OK, since when the user opens the thread dump page, the task threads are always listed as the top rows of the table, 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org