You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/07 08:16:33 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #5388: [PIP-51] Introduce sticky consumer

sijie commented on a change in pull request #5388: [PIP-51] Introduce sticky consumer
URL: https://github.com/apache/pulsar/pull/5388#discussion_r343520564
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -250,6 +255,16 @@ message AuthData {
     optional bytes auth_data = 2;
 }
 
+enum KeySharedMode {
+    autoSplit = 0;
 
 Review comment:
   can you use upper case for enums?
   
   ```
   AUTO_SPLIT = 0;
   STICKY = 1;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services