[GitHub] [pulsar] liketic commented on a change in pull request #4436: Fix log format for module pulsar-client

[GitBox <gi...@apache.org>]

liketic commented on a change in pull request #4436: Fix log format for module pulsar-client
URL: https://github.com/apache/pulsar/pull/4436#discussion_r289603953
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
 ##########
 @@ -342,9 +342,7 @@ public void run(Timeout timeout) throws Exception {
                 return;
             }
 
-            if (log.isDebugEnabled()) {
-                log.debug("[{}]  run partitionsAutoUpdateTimerTask for partitioned producer: {}", topic);
-            }
+            log.debug("[{}] run partitionsAutoUpdateTimerTask for partitioned producer", topic);
 
 Review comment:
   Thank you @sijie . What's the benefits of using log.isDebugEnabled here?  From what I understood, ```log.isDebugEnabled``` only useful for performance consideration, and the the method ```log.debug``` will also check if current log level is DEBUG. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services