You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by br...@apache.org on 2018/08/29 03:10:38 UTC
[5/5] hadoop git commit: HDFS-13854. RBF: The ProcessingAvgTime and
ProxyAvgTime should display by JMX with ms unit. Contributed by yanghuafeng.
HDFS-13854. RBF: The ProcessingAvgTime and ProxyAvgTime should display by JMX with ms unit. Contributed by yanghuafeng.
(cherry picked from commit 64ad0298d441559951bc9589a40f8aab17c93a5f)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/42da1c5c
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/42da1c5c
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/42da1c5c
Branch: refs/heads/branch-2.9
Commit: 42da1c5cf008f5f4897a70538208392d116a56aa
Parents: 13f29d4
Author: Brahma Reddy Battula <br...@apache.org>
Authored: Wed Aug 29 08:29:50 2018 +0530
Committer: Brahma Reddy Battula <br...@apache.org>
Committed: Wed Aug 29 08:33:04 2018 +0530
----------------------------------------------------------------------
.../federation/metrics/FederationRPCMetrics.java | 13 ++-----------
.../metrics/FederationRPCPerformanceMonitor.java | 15 +++++----------
2 files changed, 7 insertions(+), 21 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/42da1c5c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCMetrics.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCMetrics.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCMetrics.java
index 9ab4e5a..cce4b86 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCMetrics.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCMetrics.java
@@ -86,15 +86,6 @@ public class FederationRPCMetrics implements FederationRPCMBean {
}
/**
- * Convert nanoseconds to milliseconds.
- * @param ns Time in nanoseconds.
- * @return Time in milliseconds.
- */
- private static double toMs(double ns) {
- return ns / 1000000;
- }
-
- /**
* Reset the metrics system.
*/
public static void reset() {
@@ -230,7 +221,7 @@ public class FederationRPCMetrics implements FederationRPCMBean {
@Override
public double getProxyAvg() {
- return toMs(proxy.lastStat().mean());
+ return proxy.lastStat().mean();
}
@Override
@@ -250,7 +241,7 @@ public class FederationRPCMetrics implements FederationRPCMBean {
@Override
public double getProcessingAvg() {
- return toMs(processing.lastStat().mean());
+ return processing.lastStat().mean();
}
@Override
http://git-wip-us.apache.org/repos/asf/hadoop/blob/42da1c5c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java
index 2c2741e..15725d1 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java
@@ -35,6 +35,8 @@ import org.slf4j.LoggerFactory;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import static org.apache.hadoop.util.Time.monotonicNow;
+
/**
* Customizable RPC performance monitor. Receives events from the RPC server
* and aggregates them via JMX.
@@ -120,12 +122,12 @@ public class FederationRPCPerformanceMonitor implements RouterRpcMonitor {
@Override
public void startOp() {
- START_TIME.set(this.getNow());
+ START_TIME.set(monotonicNow());
}
@Override
public long proxyOp() {
- PROXY_TIME.set(this.getNow());
+ PROXY_TIME.set(monotonicNow());
long processingTime = getProcessingTime();
if (processingTime >= 0) {
metrics.addProcessingTime(processingTime);
@@ -188,13 +190,6 @@ public class FederationRPCPerformanceMonitor implements RouterRpcMonitor {
metrics.incrRouterFailureLocked();
}
- /**
- * Get current time.
- * @return Current time in nanoseconds.
- */
- private long getNow() {
- return System.nanoTime();
- }
/**
* Get time between we receiving the operation and sending it to the Namenode.
@@ -214,7 +209,7 @@ public class FederationRPCPerformanceMonitor implements RouterRpcMonitor {
*/
private long getProxyTime() {
if (PROXY_TIME.get() != null && PROXY_TIME.get() > 0) {
- return getNow() - PROXY_TIME.get();
+ return monotonicNow() - PROXY_TIME.get();
}
return -1;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org