You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "BharatDeva (via GitHub)" <gi...@apache.org> on 2026/06/04 00:21:09 UTC
[PR] Clean up core XML serializers (hop)
BharatDeva opened a new pull request, #7225:
URL: https://github.com/apache/hop/pull/7225
## Summary
This cleans up the XML serialization code for three core classes:
- `Result.getXml()`
- `ResultFile.getXml()`
- `ValueMetaAndData.getXml()`
The serializers now use `StringBuilder` and `XmlHandler.openTag(...)` / `XmlHandler.closeTag(...)` consistently instead of mixing helper calls with manual string concatenation.
While updating `Result.getXml()`, I also made it safe for `Result.lightClone()`. A light clone intentionally does not copy rows, so `getXml()` should still be able to emit an empty `<result-rows>` section instead of assuming the rows list is always present.
## Testing
Focused core tests:
```powershell
.\mvnw.cmd -pl core -Dtest=ResultTest,ResultFileTest,ValueMetaAndDataTests test
```
Result:
```text
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS
```
Whitespace check:
```powershell
git show --check --oneline --summary HEAD
```
Result:
```text
1c5d40db Clean up core XML serializers
```
## Issues
Fixes #6951
Fixes #6952
Fixes #6953
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up core XML serializers (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #7225:
URL: https://github.com/apache/hop/pull/7225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org