Re: cvs commit: apr-util/xml apr_xml.c

[jean-frederic clere <jf...@Fujitsu-Siemens.com>]

Joe Orton wrote:
> On Wed, Jun 23, 2004 at 04:10:58PM +0200, jean-frederic clere wrote:
> 
>>>Why take a convset if this can only convert to EBCDIC? You know that the
>>>tree is in UTF-8 so there is no other variable for the caller to
>>>control.
>>
>>The convset I have used is ap_hdrs_from_ascii. (APR_DEFAULT_CHARSET, 
>>"ISO8859-1") that is fixed.
> 
> 
> It's broken then - the XML parser returns UTF-8.
> 
> It looks like the code will silently corrupt any part of the DOM tree
> which can't be entirely converted to EBCDIC, since it ignores the
> _conv_buffer return values, which doesn't seem acceptable to me.

Ok, I have prepared the attached patch should I apply it?

> 
> joe
> 
> 

Re: cvs commit: apr-util/xml apr_xml.c

[Joe Orton <jo...@redhat.com>]

On Tue, Jul 06, 2004 at 10:44:13AM +0200, jean-frederic clere wrote:
> Ok, I have prepared the attached patch should I apply it?

Yes, looks much better. 

joe