You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/11/29 16:27:45 UTC
Review Request 64163: Made sure only non-terminal operations use
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64163/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Repository: mesos
Description
-------
The function 'addOfferOperation' is a high-level function which can be
used to some extent manage the offer operation life cycle in the
master. In addition to managing the lifetime of offer operations, it
also maintains the state of used resources.
We already made sure to never count speculated operations as using
resources in this function. In addition, the function
'updateOfferOperation' is already capable of updating the used
resources when an offer operation becomes terminal. To complete this
division of responsibilities we in this patch extend the conditional
treatment in 'removeOfferOperation' to also take into account whether
the operation is terminal when deciding on whether to mutate the used
resources.
Diffs
-----
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
Diff: https://reviews.apache.org/r/64163/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64163: Made sure only non-terminal operations use
resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64163/#review192187
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64163/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The function 'addOfferOperation' is a high-level function which can be
> used to some extent manage the offer operation life cycle in the
> master. In addition to managing the lifetime of offer operations, it
> also maintains the state of used resources.
>
> We already made sure to never count speculated operations as using
> resources in this function. In addition, the function
> 'updateOfferOperation' is already capable of updating the used
> resources when an offer operation becomes terminal. To complete this
> division of responsibilities we in this patch extend the conditional
> treatment in 'removeOfferOperation' to also take into account whether
> the operation is terminal when deciding on whether to mutate the used
> resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64163/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64163: Made sure only non-terminal operations use
resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64163/
-----------------------------------------------------------
(Updated Nov. 30, 2017, 5 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Repository: mesos
Description
-------
The function 'addOfferOperation' is a high-level function which can be
used to some extent manage the offer operation life cycle in the
master. In addition to managing the lifetime of offer operations, it
also maintains the state of used resources.
We already made sure to never count speculated operations as using
resources in this function. In addition, the function
'updateOfferOperation' is already capable of updating the used
resources when an offer operation becomes terminal. To complete this
division of responsibilities we in this patch extend the conditional
treatment in 'removeOfferOperation' to also take into account whether
the operation is terminal when deciding on whether to mutate the used
resources.
Diffs (updated)
-----
src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095
Diff: https://reviews.apache.org/r/64163/diff/2/
Changes: https://reviews.apache.org/r/64163/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier