You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by smarthi <gi...@git.apache.org> on 2016/07/10 05:21:01 UTC
[GitHub] flink pull request #2224: {hotfix} fix errors and formatting in NiFi documen...
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2224
{hotfix} fix errors and formatting in NiFi documentation
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink fix_nifi_docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2224
----
commit 694431c1a4c580c32dfdb6472e9173c5358272a0
Author: smarthi <sm...@apache.org>
Date: 2016-07-10T05:20:01Z
{hotfix} fix errors and formatting in NiFi documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2224: [docs] {hotfix} fix errors and formatting in NiFi documen...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2224
Thank you for opening a PR. I'll fix the mentioned issue myself and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2224: [docs] {hotfix} fix errors and formatting in NiFi ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2224: [docs] {hotfix} fix errors and formatting in NiFi ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2224#discussion_r70224736
--- Diff: docs/apis/streaming/connectors/nifi.md ---
@@ -89,40 +93,51 @@ val nifiSource = new NiFiSource(clientConfig)
</div>
Here data is read from the Apache NiFi Output Port called "Data for Flink" which is part of Apache NiFi
-Site-to_site protocol configuration.
+Site-to-site protocol configuration.
#### Apache NiFi Sink
-The connector provides a Sink for writing data from Apache NiFi to Apache Flink.
+The connector provides a Sink for writing data from Apache Flink to Apache NiFi.
-The class `NiFiSink(\u2026)` provides a constructor for instantiating a `NiFiSink`. `NiFiSink(SiteToSiteClientConfig, NiFiDataPacketBuilder<T>)` constructs a `NiFiSink(\u2026)` given the client's `SiteToSiteConfig` and a `NiFiDataPacketBuilder` that converts data from Flink to `NiFiDataPacket` to be ingested by NiFi.
+The class `NiFiSink(\u2026)` provides a constructor for instantiating a `NiFiSink`.
+
+- `NiFiSink(SiteToSiteClientConfig, NiFiDataPacketBuilder<T>)` constructs a `NiFiSink(\u2026)` given the client's `SiteToSiteConfig` and a `NiFiDataPacketBuilder` that converts data from Flink to `NiFiDataPacket` to be ingested by NiFi.
Example:
<div class="codetabs" markdown="1">
<div data-lang="java" markdown="1">
{% highlight java %}
+StreamExecutionEnvironment streamExecEnv = StreamExecutionEnvironment.getExecutionEnvironment();
+
SiteToSiteClientConfig clientConfig = new SiteToSiteClient.Builder()
.url("http://localhost:8080/nifi")
.portName("Data from Flink")
.requestBatchCount(5)
.buildConfig();
-SinkFunction<NiFiDataPacket> nifiSink = new NiFiSink<>(clientConfig);
+SinkFunction<NiFiDataPacket> nifiSink = new NiFiSink<>(clientConfig, new NiFiDataPacketBuilder<T>() {...});
+
+streamExec
--- End diff --
I think that line can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---