[GitHub] [airflow] SevakAvet commented on a change in pull request #13022: Fix #12480 Add support of YAML serialisation/deserialisation in Variables

[GitBox <gi...@apache.org>]

SevakAvet commented on a change in pull request #13022:
URL: https://github.com/apache/airflow/pull/13022#discussion_r541335626



##########
File path: airflow/models/variable.py
##########
@@ -82,7 +83,7 @@ def val(cls):  # pylint: disable=no-self-argument
         return synonym('_val', descriptor=property(cls.get_val, cls.set_val))
 
     @classmethod
-    def setdefault(cls, key, default, deserialize_json=False):
+    def setdefault(cls, key, default, deserialize_json=False, deserialize_yaml=False):

Review comment:
       I was thinking about that, if we want to support more than one format, would that make sense to have a parameter like serialize /deserialize of type str, which inputs could be one of json, yaml, etc.? Don't like this because it's not backward compatible. Or this could have been another argument and original would eventually be removed. 
   I can attach some screenshots of UI tomorrow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org