You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 13:22:48 UTC

[GitHub] [flink] yanghua commented on a change in pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest

yanghua commented on a change in pull request #10972: [FLINK-15810] Add more description for FlinkKafkaProducerMigrationOperatorTest
URL: https://github.com/apache/flink/pull/10972#discussion_r373476083
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java
 ##########
 @@ -28,6 +28,12 @@
 
 /**
  * Migration test from FlinkKafkaProducer011 operator.
+ * This test depends on the resource generated by {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()}.
+ *
+ * <p>Warning: We need to rename the generated resource based on the file naming pattern specified by
+ * the {@link #getOperatorSnapshotPath(MigrationVersion)} method then
+ * copy the resource to the path also specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method.
+ * </p>
 
 Review comment:
   Thanks for your review. I have removed `</p>` tag.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services