You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/06/16 06:00:56 UTC
[GitHub] [yunikorn-k8shim] wilfred-s opened a new pull request, #617: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH
wilfred-s opened a new pull request, #617:
URL: https://github.com/apache/yunikorn-k8shim/pull/617
### What is this PR for?
Building multi architecture image fails to properly split the variant from the main architecture and binary does not change without variant.
### What type of PR is it?
* [X] - Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1810
### How should this be tested?
Local and release build should generate single and multi architecture images that work on arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #617: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #617: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH
URL: https://github.com/apache/yunikorn-k8shim/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #617: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #617:
URL: https://github.com/apache/yunikorn-k8shim/pull/617#issuecomment-1594160572
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#617](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/617?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b59e131) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/50685ae79b346e58daf184ae96a25b3a68017add?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (50685ae) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 70.84% 70.87% +0.02%
==========================================
Files 47 47
Lines 7972 7972
==========================================
+ Hits 5648 5650 +2
+ Misses 2119 2117 -2
Partials 205 205
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/617/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org