You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2018/01/26 22:17:35 UTC
[GitHub] spark pull request #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaS...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/20412
[SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSuiteBase twice
## What changes were proposed in this pull request?
KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run.
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-23242
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20412.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20412
----
commit bd124b3c23a60200c83c25b6c786795a188bb9aa
Author: Shixiong Zhu <zs...@...>
Date: 2018-01-26T22:04:12Z
Don't run KafkaSourceSuiteBase
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20412
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20412
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20412
**[Test build #4078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4078/testReport)** for PR 20412 at commit [`bd124b3`](https://github.com/apache/spark/commit/bd124b3c23a60200c83c25b6c786795a188bb9aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class KafkaSourceSuiteBase extends KafkaSourceTest `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20412
Thanks! Merging to master and 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20412
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86724/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20412
**[Test build #86724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86724/testReport)** for PR 20412 at commit [`bd124b3`](https://github.com/apache/spark/commit/bd124b3c23a60200c83c25b6c786795a188bb9aa).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20412
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20412
**[Test build #4078 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4078/testReport)** for PR 20412 at commit [`bd124b3`](https://github.com/apache/spark/commit/bd124b3c23a60200c83c25b6c786795a188bb9aa).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20412
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/299/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20412
**[Test build #86724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86724/testReport)** for PR 20412 at commit [`bd124b3`](https://github.com/apache/spark/commit/bd124b3c23a60200c83c25b6c786795a188bb9aa).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class KafkaSourceSuiteBase extends KafkaSourceTest `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSu...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20412
LGTM. My bad, I should caught this in the original PR that @jose-torres made.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20412: [SPARK-23242][SS][Tests]Don't run tests in KafkaS...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/20412
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org