You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/28 15:12:50 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38023: [SPARK-40587][CONNECT] Support SELECT * in an explicit way in connect proto

grundprinzip commented on code in PR #38023:
URL: https://github.com/apache/spark/pull/38023#discussion_r982536156


##########
connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -155,4 +156,7 @@ message Expression {
     string expression = 1;
   }
 
+  // represent * (e.g. SELECT *)

Review Comment:
   ```suggestion
     // UnresolvedStar is used to expand all the fields of a relation or struct.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org