You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2009/08/31 19:01:44 UTC
svn commit: r809661 - in /tomcat/tc5.5.x/trunk/container/modules:
cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
Author: rjung
Date: Mon Aug 31 17:01:44 2009
New Revision: 809661
URL: http://svn.apache.org/viewvc?rev=809661&view=rev
Log:
Fix comment - no functional change.
The comment was misleading, because we changed
the value of the flag without correcting the comment.
Modified:
tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
Modified: tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java?rev=809661&r1=809660&r2=809661&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java (original)
+++ tomcat/tc5.5.x/trunk/container/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java Mon Aug 31 17:01:44 2009
@@ -183,7 +183,14 @@
} else {
socket = new MulticastSocket(port);
}
- socket.setLoopbackMode(false); //hint that we don't need loop back messages
+
+ /**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+ socket.setLoopbackMode(false);
+
if (mcastBindAddress != null) {
if(log.isInfoEnabled())
log.info("Setting multihome multicast interface to:" +
Modified: tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=809661&r1=809660&r2=809661&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java (original)
+++ tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java Mon Aug 31 17:01:44 2009
@@ -179,7 +179,14 @@
} else {
socket = new MulticastSocket(port);
}
- socket.setLoopbackMode(false); //hint that we don't need loop back messages
+
+ /**
+ * The argument of setLoopbackMode() is named disable.
+ * We set it to false, because we need loopback messages for the case
+ * when multiple cluster nodes reside on the same machine.
+ */
+ socket.setLoopbackMode(false);
+
if (mcastBindAddress != null) {
if(log.isInfoEnabled())
log.info("Setting multihome multicast interface to:" +mcastBindAddress);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org