[GitHub] [airflow] mik-laj edited a comment on issue #5450: [AIRFLOW-4775] - fix incorrect parameter order in GceHook

[GitBox <gi...@apache.org>]

mik-laj edited a comment on issue #5450: [AIRFLOW-4775] - fix incorrect parameter order in GceHook
URL: https://github.com/apache/airflow/pull/5450#issuecomment-504945875
 
 
   In my opinion, this PR is not correct.
   We have two static methods:
   * _check_zone_operation_status method accepts 5 arguments
   * _check_global_operation_status  method accepts 4 arguments
   
   This change applies to the second case - `_check_global_operation_status`, but 5 arguments are passed.
   
   My fixup commit is available:
   ```
   curl https://termbin.com/0mun | git am
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services