You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by rodsimpson <gi...@git.apache.org> on 2015/01/06 05:15:11 UTC

[GitHub] incubator-usergrid pull request: Usergrid 311

GitHub user rodsimpson opened a pull request:

    https://github.com/apache/incubator-usergrid/pull/140

    Usergrid 311

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rodsimpson/incubator-usergrid USERGRID-311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-usergrid/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 132b63041e74732326df31877ace542e51e37064
Author: Rod Simpson <ro...@apigee.com>
Date:   2015-01-06T03:29:02Z

    removed UpdateGroupIT, merged test into GroupResourceIT

commit ac4e0ae31601096cf4b6ce9e4556d8405a62b83c
Author: Rod Simpson <ro...@apigee.com>
Date:   2015-01-06T04:10:03Z

    fixed app level user token method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: Usergrid 311

Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/140#discussion_r22507649
  
    --- Diff: stack/rest/src/test/java/org/apache/usergrid/rest/test/resource2point0/model/Entity.java ---
    @@ -118,6 +118,10 @@ public Object get( final Object key ) {
             //All values are strings , so doing the cast here saves doing the cast elsewhere
             return getDynamicProperties().get( key );
         }
    +    public String getString( final Object key ) {
    +        //All values are strings , so doing the cast here saves doing the cast elsewhere
    +        return String.valueOf(getDynamicProperties().get( key ));
    --- End diff --
    
    you should probably cast to a string or call toString
    also could be shortened to return (String) get( key );


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-usergrid pull request: Usergrid 311

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-usergrid/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---