You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by gw...@apache.org on 2019/03/18 22:05:34 UTC
svn commit: r1855792 - in /poi/trunk: .classpath
src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java
Author: gwoolsey
Date: Mon Mar 18 22:05:34 2019
New Revision: 1855792
URL: http://svn.apache.org/viewvc?rev=1855792&view=rev
Log:
Fix a unit test that changed with the implementation of another function.
Didn't fail for me because I hadn't noticed the Eclipse classpath was out of date wrt some dependency versions, and therefore my local code was not compiling properly, meaning my test run ran old code and passed this one when it should have failed.
Modified:
poi/trunk/.classpath
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java
Modified: poi/trunk/.classpath
URL: http://svn.apache.org/viewvc/poi/trunk/.classpath?rev=1855792&r1=1855791&r2=1855792&view=diff
==============================================================================
--- poi/trunk/.classpath (original)
+++ poi/trunk/.classpath Mon Mar 18 22:05:34 2019
@@ -39,10 +39,10 @@
<classpathentry exported="true" kind="lib" path="lib/commons-collections4-4.2.jar"/>
<classpathentry kind="lib" path="lib/commons-math3-3.6.1.jar"/>
<classpathentry kind="lib" path="lib/xmlunit-core-2.5.1.jar"/>
- <classpathentry kind="lib" path="lib/mockito-core-2.21.0.jar"/>
- <classpathentry kind="lib" path="lib/byte-buddy-1.7.9.jar"/>
- <classpathentry kind="lib" path="lib/byte-buddy-agent-1.7.9.jar"/>
<classpathentry kind="lib" path="lib/objenesis-2.6.jar"/>
<classpathentry kind="lib" path="lib/commons-compress-1.18.jar"/>
+ <classpathentry kind="lib" path="lib/mockito-core-2.23.4.jar"/>
+ <classpathentry kind="lib" path="lib/byte-buddy-1.9.3.jar"/>
+ <classpathentry kind="lib" path="lib/byte-buddy-agent-1.9.3.jar"/>
<classpathentry kind="output" path="bin"/>
</classpath>
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java?rev=1855792&r1=1855791&r2=1855792&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/usermodel/ConditionalFormattingEvalTest.java Mon Mar 18 22:05:34 2019
@@ -161,19 +161,9 @@ public class ConditionalFormattingEvalTe
cfe = new ConditionalFormattingEvaluator(wb, formulaEval);
sheet = wb.getSheetAt(0);
- try {
- getRulesFor(2, 1);
- fail("Got rules when an unsupported function error was expected.");
- } catch (NotImplementedException e) {
- // expected
- }
+ assertEquals("no rules should apply", 0, getRulesFor(2, 1).size());
- try {
- getRulesFor(2, 1);
- fail("Got rules the second time when an unsupported function error was expected.");
- } catch (NotImplementedException e) {
- // expected
- }
+ assertEquals("no rules should apply", 0, getRulesFor(2, 1).size());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org