You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/14 18:59:45 UTC

[GitHub] [solr] risdenk opened a new pull request, #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

risdenk opened a new pull request, #1074:
URL: https://github.com/apache/solr/pull/1074

   https://issues.apache.org/jira/browse/SOLR-16432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk merged pull request #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1074:
URL: https://github.com/apache/solr/pull/1074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1074:
URL: https://github.com/apache/solr/pull/1074#issuecomment-1279612434

   The steps basically were:
   * Upgrade gradle wrapper - https://gradle.org/install/#with-the-gradle-wrapper
   * Ensure that gradlew and gradlew.bat still had Lucene fixes
     * https://github.com/apache/solr/blob/main/gradlew#L105
     * https://github.com/apache/solr/blob/main/gradlew.bat#L74
   * Fix any other Gradle version references (ie: sha, expected version)
   * Fix few Gradle deprecation warnings
   * incorporate gradle wrapper improvements from Lucene:
     * https://github.com/apache/lucene/pull/11766
     * https://github.com/apache/lucene/pull/11846
     
   So overall simple changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1074:
URL: https://github.com/apache/solr/pull/1074#issuecomment-1279372761

   Looks like we might have to wait for Gradle 7.6 to support JDK 19. See comments in https://issues.apache.org/jira/browse/SOLR-16432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on pull request #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1074:
URL: https://github.com/apache/solr/pull/1074#issuecomment-1279514934

   Curious; is this a straight-copy or were there edits you had to do?  I'd like to focus my attention on pertinent edits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] sonatype-lift[bot] commented on pull request #1074: SOLR-16432: Upgrade the gradle wrapper to 7.5.1

Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1074:
URL: https://github.com/apache/solr/pull/1074#issuecomment-1279400348

   :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GFBXVQ2XYBFEJREMDCSY108G?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org