[GitHub] [beam] jrmccluskey commented on a diff in pull request #26062: [#26061][Go SDK] Return server error on stream close for artifact upload.

["jrmccluskey (via GitHub)" <gi...@apache.org>]

jrmccluskey commented on code in PR #26062:
URL: https://github.com/apache/beam/pull/26062#discussion_r1157240732


##########
sdks/go/pkg/beam/runners/universal/runnerlib/stage.go:
##########
@@ -107,10 +139,10 @@ func StageViaPortableApi(ctx context.Context, cc *grpc.ClientConn, binary, st st
 	}
 }
 
-func StageFile(filename string, stream jobpb.ArtifactStagingService_ReverseArtifactRetrievalServiceClient) error {
+func stageFile(filename string, stream jobpb.ArtifactStagingService_ReverseArtifactRetrievalServiceClient) error {

Review Comment:
   I'm guessing we aren't expecting anyone to have been depending on this function being exported? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org