You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/22 11:30:01 UTC

[GitHub] [calcite] vlsi commented on issue #1681: [CALCITE-3601] Update elasticsearch tests upgrade from junit4 to junit5

vlsi commented on issue #1681: [CALCITE-3601] Update elasticsearch tests upgrade from junit4 to junit5
URL: https://github.com/apache/calcite/pull/1681#issuecomment-568253804
 
 
   It turned out to be simpler than I initially thought.
   
   I don't quite like that the PR includes javadoc re-formats for `EmbeddedElasticsearchPolicy` class, however, I'm inclined that it does not harm that much for `EmbeddedElasticsearchPolicy` because it is not that likely different PRs would edit the class.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services