You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lilykuang (via GitHub)" <gi...@apache.org> on 2023/01/30 23:10:37 UTC

[GitHub] [superset] lilykuang opened a new pull request, #22914: chore: upgrade packages for react v17 upgrade

lilykuang opened a new pull request, #22914:
URL: https://github.com/apache/superset/pull/22914

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - upgrade react-hot-loader, react-select and react-sortable-hoc for react 17 upgrade 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dpgaspar commented on a diff in pull request #22914: chore: upgrade packages for react v17 upgrade

Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #22914:
URL: https://github.com/apache/superset/pull/22914#discussion_r1091631862


##########
superset-frontend/package.json:
##########
@@ -183,13 +183,13 @@
     "react-reverse-portal": "^2.1.1",
     "react-router-dom": "^5.1.2",
     "react-search-input": "^0.11.3",
-    "react-select": "^3.1.0",
-    "react-sortable-hoc": "^1.11.0",
+    "react-select": "^3.2.0",
+    "react-sortable-hoc": "^2.0.0",

Review Comment:
   no breaking changes here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #22914: chore: upgrade packages for react v17 upgrade

Posted by codecov.
codecov[bot] commented on PR #22914:
URL: https://github.com/apache/superset/pull/22914#issuecomment-1409555796

   # [Codecov](https://codecov.io/gh/apache/superset/pull/22914?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22914](https://codecov.io/gh/apache/superset/pull/22914?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (540eff0) into [master](https://codecov.io/gh/apache/superset/commit/f2b61fca1537d0a80fafb5b313a365743cc41186?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2b61fc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #22914   +/-   ##
   =======================================
     Coverage   67.32%   67.32%           
   =======================================
     Files        1876     1876           
     Lines       72089    72089           
     Branches     7872     7872           
   =======================================
     Hits        48532    48532           
     Misses      21537    21537           
     Partials     2020     2020           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.75% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] diegomedina248 commented on a diff in pull request #22914: chore: upgrade packages for react v17 upgrade

Posted by "diegomedina248 (via GitHub)" <gi...@apache.org>.
diegomedina248 commented on code in PR #22914:
URL: https://github.com/apache/superset/pull/22914#discussion_r1091798249


##########
superset-frontend/package.json:
##########
@@ -183,13 +183,13 @@
     "react-reverse-portal": "^2.1.1",
     "react-router-dom": "^5.1.2",
     "react-search-input": "^0.11.3",
-    "react-select": "^3.1.0",
-    "react-sortable-hoc": "^1.11.0",
+    "react-select": "^3.2.0",
+    "react-sortable-hoc": "^2.0.0",

Review Comment:
   seems so, though it's no longer maintained, for v18 we'll need a replacement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lilykuang merged pull request #22914: chore: upgrade packages for react v17 upgrade

Posted by "lilykuang (via GitHub)" <gi...@apache.org>.
lilykuang merged PR #22914:
URL: https://github.com/apache/superset/pull/22914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lilykuang commented on a diff in pull request #22914: chore: upgrade packages for react v17 upgrade

Posted by "lilykuang (via GitHub)" <gi...@apache.org>.
lilykuang commented on code in PR #22914:
URL: https://github.com/apache/superset/pull/22914#discussion_r1092353148


##########
superset-frontend/package.json:
##########
@@ -183,13 +183,13 @@
     "react-reverse-portal": "^2.1.1",
     "react-router-dom": "^5.1.2",
     "react-search-input": "^0.11.3",
-    "react-select": "^3.1.0",
-    "react-sortable-hoc": "^1.11.0",
+    "react-select": "^3.2.0",
+    "react-sortable-hoc": "^2.0.0",

Review Comment:
   yes there is no breaking change for react-sortable-hoc v2 and only works up to react v17. We will need migrate from react-sortable-hoc to @dnd-kit/sortable for react v18 https://github.com/clauderic/react-sortable-hoc#readme



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org