[jclouds/jclouds] Fixes for jclouds openstack swift tests. (#1144)

[Timur Alperovich <no...@github.com>]

The ContainerApiLiveTest class has tests that mostly assume that a
single test container always exists. They collide on changes to the
state of the container. Some of the tests, though, assume the
container does _not_ exist and attempt to create it and subsequently
delete it. The change in this patch makes their behavior uniform with
respect to that test container: assume it exists and if the test tries
to delete it or mutate it, delete the container and create it at the
end of the test.

The fix in ObjectApi is for the Object GET requests. Currently,
jclouds passes "format=json", which is not a supported query parameter
for object GET.

Lastly, ObjectApiLiveTest that test server-side copy should ignore the
X-Openstack-Request-ID header, as its value will change between the
two requests.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1144

-- Commit Summary --

  * Fixes for jclouds openstack swift tests.

-- File Changes --

    M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ObjectApi.java (1)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiLiveTest.java (8)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiLiveTest.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1144.patch
https://github.com/jclouds/jclouds/pull/1144.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1144

Re: [jclouds/jclouds] Fixes for jclouds openstack swift tests. (#1144)

[Andrew Gaul <no...@github.com>]

Successfully tested against rackspace-cloudfiles-us and verified that this commit reduces openstack-swift failures from:

```
Failed tests:
  TemporaryUrlSignerLiveTest.signForPublicAccess:55 » IO Server returned HTTP re...
  ContainerApiLiveTest.testDeleteMetadata:178 » ContainerNotFound ContainerApiLi...
  ContainerApiLiveTest.testGet:156 NullPointer
  ContainerApiLiveTest.testListWithOptions:106 » IllegalState Optional.get() can...
  RegionScopedSwiftBlobStoreParallelLiveTest.setup:96->getBlobStore:84 » IllegalArgument
  ContainerApiLiveTest.testUpdateMetadata:167 » ContainerNotFound ContainerApiLi...
  ObjectApiLiveTest.testCopyObjectWithMetadata:217 Could not find: X-Openstack-Request-Id=tx8979c3b6252d4ed1818a8-0059b227fb expected [true] but found [false]

Tests run: 156, Failures: 7, Errors: 0, Skipped: 23
```

to:

```
Failed tests:
  RegionScopedSwiftBlobStoreParallelLiveTest.setup:96->getBlobStore:84 » IllegalArgument

Tests run: 156, Failures: 1, Errors: 0, Skipped: 23
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1144#issuecomment-328002165