[GitHub] [incubator-kyuubi] SteNicholas commented on a diff in pull request #2418: [KYUUBI #2346] [Improvement] Simplify FlinkProcessBuilder with java executable

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #2418:
URL: https://github.com/apache/incubator-kyuubi/pull/2418#discussion_r853989693


##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala:
##########
@@ -125,6 +124,19 @@ object FlinkSQLEngine extends Logging {
     }
   }
 
+  def executeConfigShell(): Unit = {
+    val flinkHome = System.getenv("FLINK_HOME")
+    val commands = Seq("/bin/bash", s"$flinkHome/bin/config.sh")

Review Comment:
   Please add the check whether the `FLINK_HOME` is null.



##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala:
##########
@@ -26,7 +26,10 @@ class FlinkProcessBuilderSuite extends KyuubiFunSuite {
   test("flink engine process builder") {
     val builder = new FlinkProcessBuilder("vinoyang", conf)
     val commands = builder.toString.split(' ')
-    assert(commands.exists(_ endsWith "flink-sql-engine.sh"))
+    assert(commands.head.endsWith("bin/java"), "wrong exec")

Review Comment:
   Why not directly assert the `commands.mkString(" ")`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org