[GitHub] [accumulo] keith-turner commented on a change in pull request #1197: WIP - Added a catch all for older CLI properties.

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1197: WIP - Added a catch all for older CLI properties.
URL: https://github.com/apache/accumulo/pull/1197#discussion_r292946273
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
 ##########
 @@ -82,6 +82,16 @@ public ColumnVisibility convert(String value) {
     }
   }
 
+  /**
+   * A catch all for older legacy options that have been dropped.  Most of them were replaced with
+   * accumulo-client.properties in 2.0.  Others have been dropped completely.
+   */
+  @Parameter(names = {"-p", "-tc", "--tokenClass", "-i", "--instance", "--debug", "-fake",
 
 Review comment:
   Not 100% sure about this, but I think some of these used to be boolean and therefore the parameter did not take an argument.  If this is true, it may make sense to have two groups one with with a boolean and one with a String.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services