You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/05 14:53:23 UTC

[GitHub] [skywalking-python] probeyang opened a new pull request #144: add falcon plugin

probeyang opened a new pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144


   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   
   ![image](https://user-images.githubusercontent.com/18691244/128371296-9dbf0d8f-03f7-4409-9e52-9363fae8660f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] probeyang commented on pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
probeyang commented on pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#issuecomment-893943654


   resolve conflict，too， falcon code 7010 is wrong，i will test a new case。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#issuecomment-893934222


   > i see,&nbsp; i will close the current PR, and add a new PR after fix it&nbsp;
   > […](#)
   
   You can simply fix and push to this branch, don't need to close and open over and over


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] probeyang commented on pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
probeyang commented on pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#issuecomment-893933507


   i see,&nbsp; i will close the current PR, and add a new PR after fix it&nbsp;
   
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: ***@***.***&gt;; 
   发送时间: 2021年8月6日(星期五) 上午9:21
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/skywalking-python] add falcon plugin (#144)
   
   
   
   
   
    
   @probeyang can you fix the failure in CI? It's mostly because of code style
    flake8 . --count --max-complexity=15 --max-line-length=120 35 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 36 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 37 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 38 ./tests/plugin/sw_falcon/test_falcon.py:25:1: E302 expected 2 blank lines, found 1 39 ./tests/plugin/sw_falcon/services/consumer.py:26:1: E302 expected 2 blank lines, found 1 40 ./tests/plugin/sw_falcon/services/consumer.py:31:1: E305 expected 2 blank lines after class or function definition, found 1 41 ./tests/plugin/sw_falcon/services/consumer.py:31:40: W292 no newline at end of file 42 ./tests/plugin/sw_falcon/services/provider.py:28:1: E302 expected 2 blank lines, found 1 43 ./tests/plugin/sw_falcon/services/provider.py:33:1: E305 expected 2 blank lines after class or function definition, found 1 44 ./tests/plugin/sw_falcon/services/provider.py:33:40: W292 no newline at end of file  
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#issuecomment-893932740


   @probeyang can you fix the failure in CI? It's mostly because of code style
   
   ```
   flake8 . --count --max-complexity=15 --max-line-length=120
   35
   ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file
   36
   ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file
   37
   ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file
   38
   ./tests/plugin/sw_falcon/test_falcon.py:25:1: E302 expected 2 blank lines, found 1
   39
   ./tests/plugin/sw_falcon/services/consumer.py:26:1: E302 expected 2 blank lines, found 1
   40
   ./tests/plugin/sw_falcon/services/consumer.py:31:1: E305 expected 2 blank lines after class or function definition, found 1
   41
   ./tests/plugin/sw_falcon/services/consumer.py:31:40: W292 no newline at end of file
   42
   ./tests/plugin/sw_falcon/services/provider.py:28:1: E302 expected 2 blank lines, found 1
   43
   ./tests/plugin/sw_falcon/services/provider.py:33:1: E305 expected 2 blank lines after class or function definition, found 1
   44
   ./tests/plugin/sw_falcon/services/provider.py:33:40: W292 no newline at end of file
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
tom-pytel commented on a change in pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#discussion_r683678767



##########
File path: skywalking/__init__.py
##########
@@ -40,6 +40,7 @@ class Component(Enum):
     Sanic = 7007
     AioHttp = 7008
     Pyramid = 7009
+    Falcon = 7010

Review comment:
       This must be an old original source commit since the Component IDs 7010 and 7011 have been reserved for a bit:
   ```
       Psycopg = 7010
       Celery = 7011
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] probeyang closed pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
probeyang closed pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#discussion_r683562508



##########
File path: skywalking/__init__.py
##########
@@ -40,6 +40,7 @@ class Component(Enum):
     Sanic = 7007
     AioHttp = 7008
     Pyramid = 7009
+    Falcon = 7010

Review comment:
       Can you add this component in the main repo and add a logo in the UI repo?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #144: add falcon plugin

Posted by GitBox <gi...@apache.org>.
tom-pytel commented on a change in pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#discussion_r683680169



##########
File path: skywalking/__init__.py
##########
@@ -40,6 +40,7 @@ class Component(Enum):
     Sanic = 7007
     AioHttp = 7008
     Pyramid = 7009
+    Falcon = 7010

Review comment:
       See below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org