You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/04/29 09:58:51 UTC
[Impala-ASF-CR] Checking the bitwidths in the encoded input.
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13153
Change subject: Checking the bitwidths in the encoded input.
......................................................................
Checking the bitwidths in the encoded input.
Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898
---
M be/src/exec/parquet/parquet-delta-coder-test.cc
M be/src/exec/parquet/parquet-delta-decoder.h
2 files changed, 56 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/13153/1
--
To view, visit http://gerrit.cloudera.org:8080/13153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898
Gerrit-Change-Number: 13153
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] Checking the bitwidths in the encoded input.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13153 )
Change subject: Checking the bitwidths in the encoded input.
......................................................................
Patch Set 1:
No Builds Executed
--
To view, visit http://gerrit.cloudera.org:8080/13153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898
Gerrit-Change-Number: 13153
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:20:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Checking the bitwidths in the encoded input.
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has abandoned this change. ( http://gerrit.cloudera.org:8080/13153 )
Change subject: Checking the bitwidths in the encoded input.
......................................................................
Abandoned
Opened by mistake.
--
To view, visit http://gerrit.cloudera.org:8080/13153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898
Gerrit-Change-Number: 13153
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Checking the bitwidths in the encoded input.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13153 )
Change subject: Checking the bitwidths in the encoded input.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h
File be/src/exec/parquet/parquet-delta-decoder.h:
http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h@150
PS1, Line 150: /// TODO: We should check if the bitwidths are at most 64, otherwise we have UB or crash.
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h@154
PS1, Line 154:
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/13153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898
Gerrit-Change-Number: 13153
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:11:42 +0000
Gerrit-HasComments: Yes