You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2014/07/17 08:26:59 UTC
Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc template
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/
-----------------------------------------------------------
Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
Bugs: CLOUDSTACK-6983
https://issues.apache.org/jira/browse/CLOUDSTACK-6983
Repository: cloudstack-git
Description
-------
added a check for tar.gz format in checktemplate
Diffs
-----
utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de
Diff: https://reviews.apache.org/r/23603/diff/
Testing
-------
manually tested register template on lxc
Thanks,
Rajani Karuturi
Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc
template
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/#review48212
-----------------------------------------------------------
Ship it!
Ship It!
- Kishan Kavala
On July 21, 2014, 3:23 p.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23603/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 3:23 p.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6983
> https://issues.apache.org/jira/browse/CLOUDSTACK-6983
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a check for tar.gz format in checktemplate
>
>
> Diffs
> -----
>
> utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de
>
> Diff: https://reviews.apache.org/r/23603/diff/
>
>
> Testing
> -------
>
> manually tested register template on lxc
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc
template
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/#review48211
-----------------------------------------------------------
Commit 58bad41910970fb3b08aa4d21875af6d04c8bf2e in cloudstack's branch refs/heads/master from Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58bad41 ]
Fixed CLOUDSTACK-6983: unable to register lxc template
added a check for tar.gz format in checktemplate
- ASF Subversion and Git Services
On July 21, 2014, 9:53 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23603/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 9:53 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6983
> https://issues.apache.org/jira/browse/CLOUDSTACK-6983
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a check for tar.gz format in checktemplate
>
>
> Diffs
> -----
>
> utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de
>
> Diff: https://reviews.apache.org/r/23603/diff/
>
>
> Testing
> -------
>
> manually tested register template on lxc
>
>
> Thanks,
>
> Rajani Karuturi
>
>
Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc
template
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/
-----------------------------------------------------------
(Updated July 21, 2014, 9:53 a.m.)
Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
Changes
-------
updated the patch
Bugs: CLOUDSTACK-6983
https://issues.apache.org/jira/browse/CLOUDSTACK-6983
Repository: cloudstack-git
Description
-------
added a check for tar.gz format in checktemplate
Diffs (updated)
-----
utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de
Diff: https://reviews.apache.org/r/23603/diff/
Testing
-------
manually tested register template on lxc
Thanks,
Rajani Karuturi
Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc
template
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/#review48201
-----------------------------------------------------------
utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java
<https://reviews.apache.org/r/23603/#comment84556>
You can add isCorrectExtension check for tar file type
- Kishan Kavala
On July 17, 2014, 11:56 a.m., Rajani Karuturi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23603/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6983
> https://issues.apache.org/jira/browse/CLOUDSTACK-6983
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added a check for tar.gz format in checktemplate
>
>
> Diffs
> -----
>
> utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de
>
> Diff: https://reviews.apache.org/r/23603/diff/
>
>
> Testing
> -------
>
> manually tested register template on lxc
>
>
> Thanks,
>
> Rajani Karuturi
>
>