You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jack (Jira)" <ji...@apache.org> on 2019/12/16 15:51:00 UTC
[jira] [Commented] (AIRFLOW-3189) DbAPI get_uri returns invalid uri
if schema is None
[ https://issues.apache.org/jira/browse/AIRFLOW-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997402#comment-16997402 ]
jack commented on AIRFLOW-3189:
-------------------------------
[~zuku] seems close to another PR you submitted you might be interested in this
> DbAPI get_uri returns invalid uri if schema is None
> ---------------------------------------------------
>
> Key: AIRFLOW-3189
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3189
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 1.10.0
> Reporter: Thomas Haederle
> Priority: Minor
>
> the current implementation of get_uri attaches the schema name to the URI even if no schema was specified.
> This leads to errors in downstream functions such as returning an invalid sqlalchemy engine.
> we should add a simple check, such when the schema is None, it should not be appended to the URI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)