You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/27 14:56:28 UTC

[GitHub] [superset] EBoisseauSierra opened a new pull request, #19870: docs: Detail front-end development instructions

EBoisseauSierra opened a new pull request, #19870:
URL: https://github.com/apache/superset/pull/19870

   ### SUMMARY
   
   Based on the silly error that led to [this
   discussion](https://apache-superset.slack.com/archives/C014LS99C1K/p1650969237848999),
   we clarify that when modifying the front-end locally, one should access
   the Webpack dev servers, rather than Flask directly, to see the latest
   changes take effect.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   n/a
   
   ### TESTING INSTRUCTIONS
   
   n/a
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EBoisseauSierra commented on a diff in pull request #19870: docs: Detail front-end development instructions

Posted by GitBox <gi...@apache.org>.
EBoisseauSierra commented on code in PR #19870:
URL: https://github.com/apache/superset/pull/19870#discussion_r860873868


##########
CONTRIBUTING.md:
##########
@@ -568,7 +571,15 @@ There are three types of assets you can build:
 
 #### Webpack dev server
 
-The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`. It's possible to change these settings:
+The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`.
+
+Concretely, it means that you will want to:
+
+1. [run Superset locally](#flask-server) using Flask, on port `8088`,
+2. in parallel, run the Webpack dev server locally on port `9000`,

Review Comment:
   Thanks! Would [that](https://github.com/apache/superset/pull/19870/commits/94aab8f6815e9f76d3e58bfde911d7bf33547624) make things clearer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on a diff in pull request #19870: docs: Detail front-end development instructions

Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19870:
URL: https://github.com/apache/superset/pull/19870#discussion_r860273172


##########
CONTRIBUTING.md:
##########
@@ -568,7 +571,15 @@ There are three types of assets you can build:
 
 #### Webpack dev server
 
-The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`. It's possible to change these settings:
+The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`.
+
+Concretely, it means that you will want to:
+
+1. [run Superset locally](#flask-server) using Flask, on port `8088`,
+2. in parallel, run the Webpack dev server locally on port `9000`,

Review Comment:
   Not sure if this is a good place to mention that you can run `npm run dev` or (what most people do) `npm run dev-server` for hot reloading



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #19870: docs: Detail front-end development instructions

Posted by GitBox <gi...@apache.org>.
rusackas merged PR #19870:
URL: https://github.com/apache/superset/pull/19870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org