[GitHub] [helix] jiajunwang commented on a change in pull request #655: Add an option for using dedicated ZkConnection in ZkBaseDataAccessor

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #655: Add an option for using dedicated ZkConnection in ZkBaseDataAccessor
URL: https://github.com/apache/helix/pull/655#discussion_r357300753
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
 ##########
 @@ -56,6 +57,24 @@
 import org.slf4j.LoggerFactory;
 
 public class ZkBaseDataAccessor<T> implements BaseDataAccessor<T> {
+
+  // Designates which mode ZkBaseDataAccessor should be created in. If not specified, it will be
+  // created on SHARED mode.
+  enum ZkClientType {
 
 Review comment:
   I like this type. But I would prefer if we can put it in the HelixZkClientFactory layer. There are multiple options, either we add a method in a default factory implementation so it will generate both types of the ZkClient accordingly. Or we have util for that purpose to minimize the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org