You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/14 07:53:01 UTC
[GitHub] [skywalking] nisiyong opened a new issue #6750: Why remove the query `getGlobalBrief` logic?
nisiyong opened a new issue #6750:
URL: https://github.com/apache/skywalking/issues/6750
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [X] Question or discussion
___
### Question
Hi, @wu-sheng. I noticed you remove the query `getGlobalBrief` logic, and keep it return mock data.
I have tried to find why from issue or PR, but there was nothing about that. I wanna know why? Because I think the query `getGlobalBrief` is useful, has there some problems?
`org.apache.skywalking.oap.query.graphql.resolver.MetadataQuery#getGlobalBrief`
```java
/**
* @return all 0 of metadata.
*/
@Deprecated
public ClusterBrief getGlobalBrief(final Duration duration) throws IOException, ParseException {
return new ClusterBrief();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] nisiyong commented on issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
nisiyong commented on issue #6750:
URL: https://github.com/apache/skywalking/issues/6750#issuecomment-819384978
Agree, thanks. By the way, I just want to add `ServiceBrief` like `GlobalBrief` in our internal system, we can do it by ourselves base on the SkyWalking core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6750:
URL: https://github.com/apache/skywalking/issues/6750#issuecomment-819348686
> You mean the backend has metadata, but the current UI doesn't want to show that?
Yes. We can't find the points of showing how many services/instances/endpoints. SkyWalking is not a BI system, APM doesn't care the number of them, it cares the performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6750:
URL: https://github.com/apache/skywalking/issues/6750#issuecomment-819390419
> By the way, I just want to add ServiceBrief like GlobalBrief in our internal system, we can do it by ourselves base on the SkyWalking core.
It is totally fine to do anything you believe useful in the private version. :) This is common in the open source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] nisiyong commented on issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
nisiyong commented on issue #6750:
URL: https://github.com/apache/skywalking/issues/6750#issuecomment-819346980
> Because there is no metadata query available on the UI.
You mean the backend has metadata, but the current UI doesn't want to show that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6750:
URL: https://github.com/apache/skywalking/issues/6750#issuecomment-819326726
Because there is no metadata query available on the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6750: Why remove the query `getGlobalBrief` logic?
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6750:
URL: https://github.com/apache/skywalking/issues/6750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org