[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #5213: NIFI-8779 correct Docker build scripts

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on a change in pull request #5213:
URL: https://github.com/apache/nifi/pull/5213#discussion_r672606873



##########
File path: nifi-docker/dockerhub/DockerBuild.sh
##########
@@ -13,24 +15,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-#!/bin/bash
-
-DOCKER_UID=1000
-if [ -n "$1" ]; then
-  DOCKER_UID="$1"
-fi
+set -e
+set -o pipefail
 
-DOCKER_GID=1000
-if [ -n "$2" ]; then
-  DOCKER_GID="$2"
-fi
+DOCKER_UID="${1:-1000}"
+DOCKER_GID="${2:-1000}"
+MIRROR="${3:-https://archive.apache.org/dist}"
+BASE="${4:-${MIRROR}}"

Review comment:
       That adds a jq dependency on the builder's machine (unless we do that in the Dockerfile, although that means installing the dependencies before setting some of the ARG/ENV, and that feels wrong)
   
   Also, in_dist appears to always be false (chewing 1.13.2, 1.14.p, 1.15.0 and 1.15.0-SNAPSHOT), so we'll always build from the default archive site, which won't contain the in-progress RC artifacts. Unless I'm missing something (I've got no idea what the link is that you've referenced, so don't know what creates/updates it, etc.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org