[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3835: Refactor Expr::BinaryExpr to use a struct

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3835:
URL: https://github.com/apache/arrow-datafusion/pull/3835#discussion_r995775655


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -462,13 +462,13 @@ impl DefaultPhysicalPlanner {
     ) -> BoxFuture<'a, Result<Arc<dyn ExecutionPlan>>> {
         async move {
             let exec_plan: Result<Arc<dyn ExecutionPlan>> = match logical_plan {
-                LogicalPlan::TableScan (TableScan {
-                    source,
-                    projection,
-                    filters,
-                    fetch,
-                    ..
-                }) => {
+                LogicalPlan::TableScan(TableScan {
+                                           source,
+                                           projection,
+                                           filters,
+                                           fetch,
+                                           ..
+                                       }) => {

Review Comment:
   I'm curious why there are formatting changes like this that are unrelated to making BinaryExpr a struct. Were these changes made intentionally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org