[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10394: style: use tabs in dashboard edit pane

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#discussion_r461336059



##########
File path: superset-frontend/src/dashboard/components/AddSliceCard.jsx
##########
@@ -62,9 +66,7 @@ function AddSliceCard({
           </div>
           <div className="item">
             <span>{t('Data source')} </span>
-            <span // eslint-disable-next-line react/no-danger
-              dangerouslySetInnerHTML={{ __html: datasourceLink }}
-            />
+            <a href={datasourceUrl}>{datasourceName}</a>

Review comment:
       Bycatch - moving away from `dangerouslySetInnerHTML `




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org