You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Николай Ижиков <ni...@apache.org> on 2023/09/08 16:37:31 UTC

[REVIEW REQUEST] Move ReassignPartitionsUnitTest to java

Hello.

I’m working on [1].
The goal of ticket is to rewire `ReassignPartitionCommand` in java.

The PR that moves whole command is pretty big so it makes sense to split it.
I prepared the PR [2] that moves single test (ReassignPartitionsUnitTest) to java.

It smaller and simpler(touches only 4 files):

To review - https://github.com/apache/kafka/pull/14355
Big PR  - https://github.com/apache/kafka/pull/13247

Please, review.

[1] https://issues.apache.org/jira/browse/KAFKA-14595
[2] https://github.com/apache/kafka/pull/14355

Re: [REVIEW REQUEST] Move ReassignPartitionsUnitTest to java

Posted by Николай Ижиков <ni...@apache.org>.

Hello.

 Please, join the review if you have some spare cycles.

> 8 сент. 2023 г., в 19:37, Николай Ижиков <NI...@gmail.com> написал(а):
> 
> Hello.
> 
> I’m working on [1].
> The goal of ticket is to rewire `ReassignPartitionCommand` in java.
> 
> The PR that moves whole command is pretty big so it makes sense to split it.
> I prepared the PR [2] that moves single test (ReassignPartitionsUnitTest) to java.
> 
> It smaller and simpler(touches only 4 files):
> 
> To review - https://github.com/apache/kafka/pull/14355
> Big PR  - https://github.com/apache/kafka/pull/13247
> 
> Please, review.
> 
> [1] https://issues.apache.org/jira/browse/KAFKA-14595
> [2] https://github.com/apache/kafka/pull/14355