[GitHub] [pinot] snleee commented on a change in pull request #8067: Wire EmptySegmentPruner to routing config

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#discussion_r792047544



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerFactory.java
##########
@@ -69,7 +70,10 @@ private SegmentPrunerFactory() {
             }
           }
         }
-        segmentPruners.addAll(sortSegmentPruners(configuredSegmentPruners));
+        // sort all segment pruners so that always prune empty segments first. After that, pruned based on time

Review comment:
       Can you add the comment on why you picked the order in this way? 
   
   ```
   empty -> time -> partition
   ```
   
   If we are trying to sort them in a particular order for improving the performance, this order may not be the optimal case. (We need to put the pruner that will potentially prune the most segments to front)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org