You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/02/28 01:47:14 UTC
Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1238
This addresses bug OOZIE-1238.
https://issues.apache.org/jira/browse/OOZIE-1238
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1450561
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java 1450561
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9665/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/#review17272
-----------------------------------------------------------
Ship it!
Ship It!
- Mona Chitnis
On Feb. 28, 2013, 1:45 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9665/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 1:45 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> This addresses bug OOZIE-1238.
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9665/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/#review17192
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Feb. 28, 2013, 1:45 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9665/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 1:45 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> This addresses bug OOZIE-1238.
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9665/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/#review17270
-----------------------------------------------------------
looks fine overall except minor comment
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9665/#comment36736>
why the dependency here have partitions "dt=..;country=usa", when in the later part, the check is done against partitions "ds=/2009..." as in the coordinator xml?
- Mona Chitnis
On Feb. 28, 2013, 1:45 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9665/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 1:45 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> This addresses bug OOZIE-1238.
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9665/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/
-----------------------------------------------------------
(Updated Feb. 28, 2013, 1:45 a.m.)
Review request for oozie.
Changes
-------
Updated with Rohini's comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1238
This addresses bug OOZIE-1238.
https://issues.apache.org/jira/browse/OOZIE-1238
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9665/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1238: CoordPushCheck doesn't evaluate the
configuration section which is propogated to workflow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9665/#review17180
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java
<https://reviews.apache.org/r/9665/#comment36455>
Better error message
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/9665/#comment36457>
Pass actionid and make it static method
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/9665/#comment36452>
private static
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9665/#comment36456>
throws CommandException
- Rohini Palaniswamy
On Feb. 28, 2013, 12:47 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9665/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 12:47 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> This addresses bug OOZIE-1238.
> https://issues.apache.org/jira/browse/OOZIE-1238
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1450561
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java 1450561
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1450561
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1450561
> trunk/core/src/test/resources/coord-action-for-action-push-check.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9665/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>