[jira] [Commented] (OFBIZ-10512) Change order of parameters in runSyncIgnore

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576364#comment-16576364 ] 

Jacques Le Roux commented on OFBIZ-10512:
-----------------------------------------

+1

> Change order of parameters in runSyncIgnore
> -------------------------------------------
>
>                 Key: OFBIZ-10512
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10512
>             Project: OFBiz
>          Issue Type: Wish
>            Reporter: Niklas Fallik
>            Priority: Minor
>
> It is confusing that the order of the arguments passed to LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> {code:java}
> void runSyncIgnore(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
> {code}
>  
> {code:java}
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException; {code}
> cf.
> LocalDispatcher.java[101 + 102]
>  
> The context parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)