You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/25 21:18:20 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request #242: Add better versioning control in project.
HoustonPutman opened a new pull request #242:
URL: https://github.com/apache/solr-operator/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #242: Add better versioning control in project.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #242:
URL: https://github.com/apache/solr-operator/pull/242#discussion_r601853802
##########
File path: version/version.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package version
+
+var (
+ // Version information for the Solr Operator
+ Version string = "v0.3.0"
+ VersionSuffix string = "prerelease"
+ BuildTime string
Review comment:
I'm actually kind of lukewarm on this, the only binary releases we are doing are docker images, which have questionable reproducibility anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] madrob commented on a change in pull request #242: Add better versioning control in project.
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #242:
URL: https://github.com/apache/solr-operator/pull/242#discussion_r601847288
##########
File path: Makefile
##########
@@ -20,9 +28,13 @@ endif
all: generate
+.PHONY: version
Review comment:
isn't tag also PHONY?
##########
File path: version/version.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package version
+
+var (
+ // Version information for the Solr Operator
+ Version string = "v0.3.0"
+ VersionSuffix string = "prerelease"
+ BuildTime string
Review comment:
We don't want this because it means that builds are not reproducible. There may be other reasons that the build is not reproducible, but this we shouldn't add to it if we can help it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #242: Add better versioning control in project.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #242:
URL: https://github.com/apache/solr-operator/pull/242#discussion_r601851119
##########
File path: version/version.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package version
+
+var (
+ // Version information for the Solr Operator
+ Version string = "v0.3.0"
+ VersionSuffix string = "prerelease"
+ BuildTime string
Review comment:
Maybe we bake this in during a release, therefore it would be reproducible? Rename it "Release Date" or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #242: Add better versioning control in project.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #242:
URL: https://github.com/apache/solr-operator/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org