You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2015/12/03 09:11:58 UTC
[GitHub] cloudstack pull request: [UI] fix bug: Cannot delete SSH keypairs ...
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1154
[UI] fix bug: Cannot delete SSH keypairs in projects
Before change:
error message: ProjectId and account/domainId can't be specified together
After change:
SSH keypairs can be removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack fix-ui-delete-sshkey-projects
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1154
----
commit e9cc5551d310c288a4b5ff748eee00951020f9a2
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-12-03T08:07:48Z
[UI] fix bug: Cannot delete SSH keypairs in projects
Before change:
error message: ProjectId and account/domainId can't be specified together
After change:
SSH keypairs can be removed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [UI] fix bug: Cannot delete SSH keypairs ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [UI] fix bug: Cannot delete SSH keypairs ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1154#issuecomment-162416559
LGTM, merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [UI] fix bug: Cannot delete SSH keypairs ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1154#issuecomment-162336048
code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---