[GitHub] [ignite] ololo3000 commented on a change in pull request #8937: IGNITE-14428 Formalizes the names of the metrics included in the metric registry.

[GitBox <gi...@apache.org>]

ololo3000 commented on a change in pull request #8937:
URL: https://github.com/apache/ignite/pull/8937#discussion_r604698730



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/MetricRegistry.java
##########
@@ -115,12 +116,19 @@ public void reset() {
     }
 
     /**
-     * Register existing metrics in this group with the specified name.
+     * Register existing metrics in this group with the specified name. Note that the name of the metric must
+     * start with the name of the current registry it is registered into.
      *
      * @param metric Metric.
      */
     public void register(Metric metric) {
-        addMetric(metric.name(), metric);
+        String fullName = metric.name();

Review comment:
       Done.

##########
File path: modules/core/src/test/java/org/apache/ignite/internal/metric/MetricsSelfTest.java
##########
@@ -130,11 +131,13 @@ public void testIntCounter() throws Exception {
     /** */
     @Test
     public void testRegister() throws Exception {
-        AtomicLongMetric l = new AtomicLongMetric("rtest", "test");
+        String mName = "rtest";

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org